This topic has 5 replies, 3 voices, and was last updated 9 years by Reflect Growth.
-
Author
-
October 12, 2015 at 04:27 #81829Reflect GrowthParticipant
I’ve been optimising Kleo recently and have updated to using WP-Minify-Fix to minify (and combine) my html, js and css files.
I noticed that when doing this, the homepage of my site was affected. I have a section with three tabs, each of which contain a carousel of images in one half and text in the other. The first tab contents load fine, however tabs two and three don’t load the image carousel correctly. See my site (as per private from field) under the section “WE ARE THE LEADERS WE’VE BEEN WAITING FOR” about half way down the page.
The following issues can be seen:
- In tab two “Learning”: the image tags don’t get injected into the html at all, so the carousel appears empty and non-functional.
- In tab three “Teaching”: the image tags are injected correctly but the wrapper limits the image width to 100px so I end up with tiny scrolling images aligned to the left.
So far I have:
- Disabled html, css & js minification to validate that this issue is within the minification process.
- Identified that only js minification affects the issue.
- Excluded: the following files from minification:
- wsi-public.js (WordPress Social Invites)
- app.min.js (From the Kleo theme) – As I’d observed many broken features on the site with this included
- init.js (From the Kleo theme) – As recommended on another support thread
- modernizr.custom.46504.js (From the Kleo theme) – As recommended on another support thread
- jquery.carouFredSel-6.2.0-packed.js (From the Kleo theme) – Just in case this affected the issue, but hasn’t remedied the problems by excluding it.
Have you heard of these issues before? Can you think of any specific scripts that I should also exclude from minification to remedy this?
It’s worth noting that this issues aside I haven’t got any errors reported in the developer console of chrome and that the issue presents itself within Firefox and Internet Explorer also.
Would really value your input, as I’ve exhausted my diagnosis without beginning to delve into the Kleo code – and I know you guys are far more qualified to know if this is anything do do with your theme 🙂
Many thanks, Matt
October 14, 2015 at 02:58 #82174LauraModeratorHello, will assign the ticket to a higher support lever who can help and advise you in your query.
Thanks! 🙂Hi there!!! Help others from the community and mark any reply as solution if it solved your question. Mark as a solutionLaura Solanes - Graphic Designer and Web Designer
Please be patient as I try to answer each topic as fast as i can.
If you like the theme or the support you've received please consider leaving us a review on Themeforest!
Always happy to help you 🙂
October 14, 2015 at 09:12 #82196Reflect GrowthParticipant@Laura – thank you that would be awesome 🙂 Much appreciated.
Regards, Matt
October 14, 2015 at 11:30 #82208Reflect GrowthParticipantIt’s worth noting that I’ve been observing other issues to relating to combining* JS too:
- Duplicate activity status messages – as commented over on this support thread: https://archived.seventhqueen.com/forums/topic/activity-stream-multiple-posts-with-every-post/#post-82197
- Media attachment issues on statuses – when attaching images as part of an activity statement, the image is not included and left unloaded
On face value it seems there’s some issues with the JS scripts conflicting when combined*. Perhaps namespace issues / conflicts?
*Note: I have tested with “combine files but do not minify” enabled and this does not affect the issues observed, leading me to think it’s related to combining files only (as opposed to a minification issue directly).
October 14, 2015 at 12:39 #82212AndreiModeratorPlease consider using the “Better WordPress Minify” plugin, which was tested by us and didn’t created any issue. Also it comes with a ton of great features to manage the way your resources are loaded and minified.
Cheers
Hi there!!! Help others from the community and mark any reply as solution if it solved your question. Mark as a solutionOctober 15, 2015 at 08:20 #82345Reflect GrowthParticipantThanks @andrei given that a blast and all the issues have gone away! Thank you 🙂
-
AuthorPosts
The forum ‘Bugs & Issues’ is closed to new topics and replies.