Forum Replies Created
-
-
Sorry, I forgot to enable development mode; it works if enabled. Hope it will work without development mode in the update.
Many thanks for your support!
Great! Thanks a lot!
By the way, replacing wp-content/themes/kleo/assets/js/app.js
with https://pastebin.com/raw/BNPhEN7r did not work.Radu, the name attribute in the a tag was deprecated in HTML5, but all browsers still support it. It is really a very common HTML feature. I’ve used this attribute a thousand times and of course the browser will jump directly to a position if you link to it from an external site or open the URL directly.
Try this: https://www.w3.org/TR/html4/struct/links.html#h-12.3
The browser will jump directly to the anchor name. And this is the code they use: 12.3. As you see, no id needed.Replacing a file in the theme is not really a solution because this will be overwritten with the next update.
The name attribute in anchors also worked before with Kleo and I am 100% certain because I used such links many times since we work with Kleo. The bug must have been introduced recently in Kleo and it is definitely a JavaScript bug because the links work just fine with disabled JavaScript in the browser.
Forward this to the theme developer. I am sure he or she will want to fix this bug.
You have to disable JavasScript in the browser, save the settings and then open a new tab where you paste the URL. It does not work if you just reload the page. I just tried it again with Chrome on a Mac and the anchors work when I disable JavaScript.
Besides, the anchors work in any other modern theme. Try the Twenty Fifteen theme that comes with WordPress and the Better Anchor Links plugin. You can find more about the name attribute and fragment identifiers here: https://stackoverflow.com/questions/484719/html-anchors-with-name-or-id
I cannot start replacing legitimate name attributes on a site with more than 10,000 pages because of a bug in a theme.
Can you fix this bug in Kleo?
Thanks for the reply. You are right, it works with id attributes, although the id doesn’t have to be added to a div. It also works with with a tags.
However, this is a bug in Kleo. The problem is not an HTML issue. Our HTML is okay. We just use name attributes instead of id attributes for the anchor. The corresponding a tag is right above the h2 tag.
If I disable JavaScript in the browser, the links work. This JavaScript code that breaks the links must come from Kleo.
We have used name attributes many times in the last 12 years and Kleo now breaks all those links. I am sure we are not only ones who have this problem now with Kleo.
Can you fix this bug in Kleo?
Well, kleo_bp_activity_filter does not really remove shortcodes. The filter removes square brackets which is a problem because members can’t post code properly this way. Most programming languages require square brackets.
Besides, as far as I know BuddyPress removes all registered shortcodes from activity updates anyway. So I think you don’t really need kleo_bp_activity_filter.
Anyway, I am fine with removing the filter in functions.php. I am just reluctant to remove other people’s filter if I don’t fully understand what they are good for.
Thanks for the replies!
Thanks! I have an idea now what causes the issue, but I need to verify it when the problem occurs again. I added the code below to functions.php, so I will get an email whenever Kleo options are updated. I will then have a closer look.
add_action(‘update_option’, function( $option_name, $old_value, $value) {
if(preg_match(‘/.*kleo.*/’, $option_name)) {
$old_value = print_r($old_value, true);
$value = print_r($value, true);
$log = $option_name . “\nOld value:\n” . $old_value . “\nNew value:\n” . $value;
wp_mail($admin_mail, $option_name, $log);
}
}, 10, 3);I will report back if I find something, but it might take a few weeks because the problem only occurs occasionally.
Thanks a lot for the help!
There is no hosting provider because we manage the server ourselves.
Note that the problem could also be caused by the Redux Framework that Kleo is using, or perhaps by the changes you made to Redux.
Can you please tell me which function is used to load the default settings when the theme is activated for the first time? I will then look into the code myself.
Radu, thanks for the quick response.
We don’t use a database optimization plugin and deactivating and reactivating the kleo child theme works without problems. That is, the settings stay.
I checked the wp_options table now and it seems the reset was caused by the kleo_kleo-child-transients entry. When is this option_name used?
I suppose you load the default settings when the theme / child theme is activated the first time? My guess is that the corresponding function is somehow executed by mistake. Where is this function? Can I disable it?
We are now using the BuddyPress Global Search plugin. We had to adjust some CSS and remove the then incorrect number of search results displayed by Kleo. The solution is not optimal because autoload of search results with the search field in the top menu doesn’t work. The nice thing about the plugin is that it searches the entire site including BuddyPress updates, blog comments, and Bbpress. It would be nice if Kleo integrates BuddyPress Global Search in a future release.
The problem appears to be in /kleo/vc_templates/vc_posts_grid.php. If I replace line 119 with the code below, the thumbnails work:
COPY CODEquery_posts( $args ); if ( have_posts() ) : ?>This setting appears to have no effect whatsoever on Kleo Posts. If I change “Layout” to “Grid”, the thumbnails appear even if I set “Show media on post page” to “No.”
Did you test with “Layout” set to “Standard”? (See attachment)
Radu, giving you admin access to the test system would be quite complicated because you need VPN software and stuff.
But I think I’ve found the bug now. It is the theme setting in the blog section “Display media on post page.” In Kleo 4.2.5 this setting has no effect on the Kleo Post widget, but in Kleo 4.2.6 (and probably later), this setting has to be enabled to display thumbnails with the widget.
I think this is a bug in 4.2.6 because the widget behavior should only be determined by the widget settings and not by settings deep down in the theme configuration. If you enable thumbnails in the widget, the thumbnails should be disabled no matter what.
Thanks for the support.
As mentioned in my previous reply, the child theme on my test system is absolutely empty. The only file is style.css with the header, no styles. There is no functions.php or any other file in the child theme folder.
I also disabled all plugins, except the ones I mentioned above.
When I switch to Kleo 4.2.5., the thumbnails work incredibly well. I switch to 4.2.6 or later, the thumbnails disappear. Thus, we can conclude that you introduced a bug in 4.2.6 that affects the Kleo Posts widget only when a child theme is enabled.
Can you please try the configuration with an empty child theme in the configuration I described above and post your results? Also please check what changes you made in 4.2.6 that could affect the Kleo Posts widget and installations that use a child theme.
I am sorry, I can’t give third-parties admin credentials. It appears it is indeed an issue with the child theme. If I enable the core theme, the thumbnails work.
However, it appears it is a Kleo bug introduced with 4.2.6. I disabled all plugins except BuddyPress, bbpress, K-elements and Visual Composer and created an empty child theme that only contained style.css without any styles. The thumbnails disappeared with this configuration.
Can you verify this? Let me know if you need additional information.
https://hplus.club/ is publicly accessible. On the homepage scroll down to “Blog and Wiki Posts” and you will see that no thumbnails are displayed. You can do the same on https://4sysops.com which still uses Kleo 4.2.5 and you will see that the thumbnails are displayed.
I attached the settings of the Kleo Posts widget.
We reversed to Kleo 4.2.5 where the problem does not exist.The problem first appeared in 4.2.6. This site runs with 4.2.7 and the Kleo Posts widget also doesn’t show the thumbnails.
Thanks. I guess it is not really a big deal to also search in BuddyPress updates, BuddyPress comments, and WordPress comments.
Abe, works! Thanks you so much! I am very much impressed about your support. I will buy another license for another site.
I appeared to me that you are logged in with “My Account 1”. Anyway, of course I ensured that no other plugin interferes. I tried it again now.
The only active plugins were BuddyPress and BuddyPress Docs. I also switched from Kleo-Child to Kleo to ensure that nothing in our functions.php interferes. Same thing. Tag archive is not working if I am not logged in and it works when I sign in. When I switch to another theme, it also works.
Maybe the problem only occurs under certain circumstances. Maybe you had no documents in BuddyPress Docs or perhaps you didn’t set tags there. Can be anything. The only thing that is sure is that it is the combination of BuddyPress Docs and Kleo that causes the problem.
Abe, you were logged in when you tested it. As mentioned above, it only doesn’t work if you are not logged in.
I think this is not a plugin integration issue. Kleo breaks a core WordPress functionality and not a functionality of the plugin. Compatibility issues usually come up if a developer doesn’t comply with the standard. Because all other themes I have tried load the tag archive correctly if the plugin is active, I can only assume that Kleo retrieves the tag archive in a non-standard way. It is interesting to note that other archive pages are not affected. It is also very odd that the tag archive loads correctly with Kleo for logged-in users.
Anyway, thanks for looking into this.
Laura, thanks for the reply!
It appears the problem is related to the BuddyPress Docs plugin. However, I still think it is a Kleo bug because the problem does not appear with any other theme I tried. For instance, the tag archives work fine with Twenty Fifteen and with the BuddyPress Default theme. I guess the corresponding query in Kleo is non-standard.
So how can we fix this? By the way, you might want to support BuddyPress Docs in the future. It is a great community plugin.
Thanks!
Thanks. You forgot to add this:
add_action(‘the_content’, ‘prepend_excerpt);
I also wouldn’t h1 tags for the excerpt. Makes no sense.
Sorry for my somewhat rude tone. I am always like that when I have colds.
The excerpt should either be before or after the article meta. It would be great if KLEO introduces a corresponding switch in a future release. The default style should be bold, a bigger font size is also an option.
Because we probably will have the article meta on the side, the excerpt has to be right above the article content.
Because the excerpt is the second most important part (after the title) of an article when it comes to SEO. The excerpt has to be on the same page as the article and it needs a specific style. It should have a meta description tag, so search engines know what the page is about and display the excerpt on SERPS. The excerpt is also important for visitors, so they know what the article is about and can decide whether it makes sense to read ahead.
The vast majority of professional sites highlight the excerpt at the top of article. I am very much surprised that the KLEO theme doesn’t do that by default. That’s why assumed it is a bug or that a plugin interferes. No offense, but you also could have asked why the title or the author name have to be on the single page if they are already on the blog page.
Having said that, KLEO is by far the best theme I ever worked with!
Found the problem now. We had the Side Wide Activity widget in the sidebar. It seems the rtmedia button was somehow transferred from the sidebar to the main area. Removing the widget from the sidebar solved the problem.
Thanks for looking into this.
